Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add nodeselector, tolerations for zarf registry deployment using --set during zarf init #2362

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

waveywaves
Copy link
Contributor

Description

Allow setting nodeselector and tolerations for the zarf registry chart using --set while running zarf init

Related Issue

Relates to #2176

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Copy link

netlify bot commented Mar 6, 2024

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 604e952
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/65e8f1c93d210d0008c3cdd7

@waveywaves waveywaves changed the title add nodeselector, tolerations config to relevant file feat: add nodeselector, tolerations for zarf registry deployment using --set during zarf init Mar 6, 2024
@waveywaves
Copy link
Contributor Author

Plans to test

Start minikube and add the labels and taint on the nodes

minikube start
kubectl label nodes minikube disktype=ssd
kubectl taint nodes minikube zarf=taint:NoSchedule

then deploy using zarf init --set REGISTRY_TOLERATIONS='...'

How can I install the init package which is built from my latest commit in zarf. zarf init is otherwise trying to find the built image for the init package in ghcr.io

It seems the init package could not be found locally, but can be pulled from
oci://ghcr.io/defenseunicorns/packages/init:v0.32.3-32-g604e952d

@waveywaves waveywaves marked this pull request as ready for review March 7, 2024 01:05
@lucasrod16
Copy link
Member

Plans to test

Start minikube and add the labels and taint on the nodes

minikube start
kubectl label nodes minikube disktype=ssd
kubectl taint nodes minikube zarf=taint:NoSchedule

then deploy using zarf init --set REGISTRY_TOLERATIONS='...'

How can I install the init package which is built from my latest commit in zarf. zarf init is otherwise trying to find the built image for the init package in ghcr.io

It seems the init package could not be found locally, but can be pulled from
oci://ghcr.io/defenseunicorns/packages/init:v0.32.3-32-g604e952d

If you build a Zarf binary from your branch using make, you can create and deploy an init package with that locally built binary. For example, on an M1 Mac it would go as folllows:

  1. make init-package ARCH=<arm64 or amd64> this will output the init package to the build/ directory
  2. ./build/zarf-mac-apple init --confirm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: New
Development

Successfully merging this pull request may close these issues.

None yet

2 participants