Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --config flag, an alternative to ZARF_CONFIG env var #2328

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

waveywaves
Copy link
Contributor

Description

add --config flag, an alternative to ZARF_CONFIG env var

Related Issue

Fixes #2178

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Copy link

netlify bot commented Feb 22, 2024

Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit 2510d25
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/6614faf5050d2a0008134e00
😎 Deploy Preview https://deploy-preview-2328--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@waveywaves waveywaves marked this pull request as ready for review March 5, 2024 13:04
src/cmd/root.go Outdated Show resolved Hide resolved
src/test/e2e/30_config_file_test.go Outdated Show resolved Hide resolved
src/cmd/common/setup.go Outdated Show resolved Hide resolved
@AustinAbro321
Copy link
Contributor

Hey @waveywaves sorry for the delay but I would like to get this merged in at some point, I think it's pretty close. Could you merge main into this branch? There are a lot of conflicts but they're all from the new docs site so merging in main and running make docs-and-schema should fix it.

Also could you add the following line to the appropriate block in src/cmd/internal.go

addHiddenDummyFlag(toolCmd, "config-path")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: New
Development

Successfully merging this pull request may close these issues.

alternative zarf config path as a CLI option
3 participants