Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: zarf optional component negation #425

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rjferguson21
Copy link
Contributor

Description

...

Related Issue

Fixes #

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@UncleGedd
Copy link
Collaborator

Chatted with @zachariahmiller to get more context on this. @rjferguson21 would you like to implement the overrides.<component>.enabled syntax? (no pressure!)

@UncleGedd
Copy link
Collaborator

UncleGedd commented Feb 20, 2024

Context so I don't forget again: the team is requesting the ability to override the required key of a Zarf pkg component. In other words, regardless of whether a component is required in a zarf.yaml, bundle authors have the ability to enable a component during bundle creation

@rjferguson21
Copy link
Contributor Author

@UncleGedd I'd love to try to implement that.

I believe the there are technically two pieces.

  • prevent a particular zarf component that is required: false, default: true, from deploying at bundle deploy time.
  • prevent the same component from being included in the bundle at create time

I think it would be reasonable to do the first bullet, and tackle the second at a later date. /cc @zachariahmiller

@UncleGedd
Copy link
Collaborator

That sounds good, I like the idea of breaking the issue up into smaller chunks. What do you think of this syntax:

kind: UDSBundle
metadata:
  name: foo
  version: 0.0.1

packages:
  - name: podinfo
    repository: ghcr.io/defenseunicorns/uds-cli/podinfo
    ref: 0.0.1
    overrides:
      metrics-server:
        enabled: false

@UncleGedd
Copy link
Collaborator

Hey @rjferguson21 looks like Zarf is refactoring required vs optional key on their side. I recommend waiting until that behavior is finalized before implementing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants