Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove write perms image digest workflow #1677

Merged
merged 1 commit into from
Jan 16, 2025
Merged

chore: remove write perms image digest workflow #1677

merged 1 commit into from
Jan 16, 2025

Conversation

cmwylie19
Copy link
Contributor

Description

Remove excess perms from Image Digest Workflow

Related Issue

Fixes #1675

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
cmwylie19 Case Wylie
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
@cmwylie19 cmwylie19 requested a review from a team as a code owner January 16, 2025 15:47
@cmwylie19 cmwylie19 changed the title chore: remove write perms chore: remove write perms image digest workflow Jan 16, 2025
Copy link
Contributor

@samayer12 samayer12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Root cause of the issue was a project setting, not CI permissions. Good to go.

@cmwylie19 cmwylie19 added this pull request to the merge queue Jan 16, 2025
Merged via the queue into main with commit 8c466da Jan 16, 2025
47 checks passed
@cmwylie19 cmwylie19 deleted the 1675 branch January 16, 2025 16:17
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.52%. Comparing base (d500850) to head (1f01ff4).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1677   +/-   ##
=======================================
  Coverage   79.52%   79.52%           
=======================================
  Files          48       48           
  Lines        2090     2090           
  Branches      460      460           
=======================================
  Hits         1662     1662           
  Misses        398      398           
  Partials       30       30           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Image Digest Update is throwing Errors on Windows
2 participants