Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(test): fix py37 on macos #455

Merged
merged 1 commit into from
May 1, 2024
Merged

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented May 1, 2024

xref: actions/runner-images#9770

Summary by CodeRabbit

  • Chores
    • Updated testing configurations to exclude Python version 3.7 on the latest macOS for Apple Silicon ARM64 and include it on macOS 13 for Intel CPUs.

xref: actions/runner-images#9770

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Copy link
Contributor

coderabbitai bot commented May 1, 2024

Walkthrough

Walkthrough

The update to the GitHub workflow configuration specifically targets Python version compatibility across different macOS hardware. The changes ensure that Python 3.7 is excluded from testing on the latest macOS version running on Apple Silicon ARM64 hardware, while it continues to be tested on macOS-13 for Intel CPUs. This adjustment helps maintain support for legacy systems while optimizing for newer architectures.

Changes

File Path Change Summary
.github/workflows/test.yml Excluded Python 3.7 on macos-latest for ARM64; Included Python 3.7 on macos-13 for Intel CPUs

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between f13f826 and 0f7a9ff.
Files selected for processing (1)
  • .github/workflows/test.yml (1 hunks)
Additional comments not posted (1)
.github/workflows/test.yml (1)

22-27: Adjustment to Python 3.7 testing on macOS platforms aligns with compatibility requirements.

The exclusion of Python 3.7 from macos-latest and its inclusion in macos-13 ensures compatibility with the supported hardware architecture. This change is well-aligned with the external updates in macOS support for Python versions, as noted in the GitHub Actions runner images issue.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@njzjz njzjz merged commit 44c5bdf into deepmodeling:master May 1, 2024
24 checks passed
@njzjz njzjz deleted the ci-py37-macos branch May 1, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant