Change import names from v3 to v4 #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CluEleSsUK
reviewed
May 23, 2024
| "go.dedis.ch/kyber/v3/group/mod" | ||
| "go.dedis.ch/kyber/v3/pairing" | ||
| "go.dedis.ch/kyber/v3/util/random" | ||
| "go.dedis.ch/kyber/v4" |
There was a problem hiding this comment.
I'm guessing there's a reason this is all commented out, but it seems suspicious - could just nuke it
CluEleSsUK
reviewed
May 23, 2024
| @@ -1,4 +1,4 @@ | |||
| module go.dedis.ch/kyber/v3 | |||
| module go.dedis.ch/kyber/v4 | |||
|
|
|||
| go 1.18 | |||
There was a problem hiding this comment.
have we considered bumping the go version to something newer? does it break things?
There was a problem hiding this comment.
we actually have upgraded it from Go 1.13 to Go 1.18 already!
In truth it would probably be nice to update to Go 1.22 to get the new Loop behaviour, but at the same time a library like Kyber kinda wants to support older codebases too I guess.
CluEleSsUK
approved these changes
May 23, 2024
AnomalRoil
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a PR to change import and mod names from kyber/v3 to kyber/v4