Add hash to point from RFC9380 #510
Conversation
K1li4nL
force-pushed
the
kilian-add-hash-to-ed
branch
from
fc565eb
to
c04199d
Compare
| dst.SetBytes(b[:]) | ||
| } | ||
|
|
||
| func feFromBn(dst *fieldElement, src *big.Int) { |
There was a problem hiding this comment.
same, add a comment saying what it does
There was a problem hiding this comment.
Not exactly, it converts from big.Int, its fixed !
There was a problem hiding this comment.
It would be good to have some tests testing both, going both directions and weird testing edge cases (all 1s, all 0s, etc.)
| return dst, nil | ||
| } | ||
|
|
||
| func curve25519Elligator2(u fieldElement) (xn, xd, yn, yd fieldElement) { |
There was a problem hiding this comment.
Can't this also be used for Curve25519? Why put it in Edwards25519?
There was a problem hiding this comment.
Yes it can, though our Curve25519 doesn't use fieldElement but only big.Int, it would make sense to put it there but it would be of no use unfortunately.
K1li4nL
force-pushed
the
kilian-add-hash-to-ed
branch
from
49ec0f3
to
3275d0b
Compare
K1li4nL
force-pushed
the
kilian-add-hash-to-ed
branch
from
3275d0b
to
45763cc
Compare
| dst.SetBytes(b[:]) | ||
| } | ||
|
|
||
| func feFromBn(dst *fieldElement, src *big.Int) { |
There was a problem hiding this comment.
It would be good to have some tests testing both, going both directions and weird testing edge cases (all 1s, all 0s, etc.)
K1li4nL
force-pushed
the
kilian-add-hash-to-ed
branch
from
9b8b1a8
to
8b5d5fe
Compare
|
K1li4nL
force-pushed
the
kilian-add-hash-to-ed
branch
from
c17b790
to
a607602
Compare
group/edwards25519/point.go
Outdated
| h.Reset() | ||
| return uniformBytes, nil | ||
| } |
There was a problem hiding this comment.
I believe that we can remove the last h.Reset(), as you always reset it prior to updating its state.
There was a problem hiding this comment.
Its fixed, thank you very much !
|
Add Hash() on Ed25519