Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add AssetBundleConverted event #318

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Conversation

aleortega
Copy link
Contributor

No description provided.

@aleortega aleortega requested a review from a team as a code owner November 19, 2024 20:08
Copy link

github-actions bot commented Nov 19, 2024

Test this pull request

  • The package can be tested by running
    npm upgrade "https://sdk-team-cdn.decentraland.org/@dcl/schemas/branch/feat/asset-bundle-events/dcl-schemas-15.1.3-12169636681.commit-9b184b9.tgz"

additionalProperties: true
}

export const validate: ValidateFunction<AssetBundleConvertedEvent> = generateLazyValidator(schema)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if you could add a test to validate the new schema 🙏

Copy link
Contributor

@kevinszuchet kevinszuchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aleortega aleortega force-pushed the feat/asset-bundle-events branch from 67f9fb2 to ec2a03c Compare December 4, 2024 22:41

Verified

This commit was signed with the committer’s verified signature.
junderw Jonathan Underwood
@aleortega aleortega force-pushed the feat/asset-bundle-events branch from ec2a03c to df97bd4 Compare December 4, 2024 22:43
@aleortega aleortega merged commit 6c6fa87 into main Dec 4, 2024
4 checks passed
@aleortega aleortega deleted the feat/asset-bundle-events branch December 4, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants