Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent badmatch by taking an edge case into account #144

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Prevent badmatch by taking an edge case into account #144

merged 1 commit into from
Aug 22, 2022

Conversation

lukebakken
Copy link
Contributor

A couple RabbitMQ users reported badmatch crashes due to scenarios
where inet:peername/1 does not return the expected value, most likely
due to the port closing between the time they are listed and when
inet:peername/1 is called.

Discussion in rabbitmq/rabbitmq-server#5490

See rabbitmq/rabbitmq-server#5534 as well.

Thanks @deadtrickster

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
A couple RabbitMQ users reported `badmatch` crashes due to scenarios
where `inet:peername/1` does not return the expected value, most likely
due to the port closing between the time they are listed and when
`inet:peername/1` is called.

Discussion in rabbitmq/rabbitmq-server#5490
@deadtrickster deadtrickster merged commit 29d1acf into deadtrickster:master Aug 22, 2022
@lukebakken
Copy link
Contributor Author

Thanks @deadtrickster

@lukebakken lukebakken deleted the rabbitmq-server-5496 branch August 22, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants