Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cmake warning when building with -DMYSQL=ON #7886

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

BlaiZephyr
Copy link
Contributor

@BlaiZephyr BlaiZephyr commented Jan 31, 2024

closes #7881

edit:
the ubuntu 20.04 check is failing - i cant exactly tell why, i assume its because of:

CMake Error at CMakeLists.txt:642 (message):
You must install MySQL to compile the DDNet server with MySQL support

Checklist

  • Tested the change ingame
  • Provided screenshots if it is a visual change
  • Tested in combination with possibly related configuration options
  • Written a unit test (especially base/) or added coverage to integration test
  • Considered possible null pointers and out of bounds array indexing
  • Changed no physics that affect existing maps
  • Tested the change with ASan+UBSan or valgrind's memcheck (optional)

@BlaiZephyr BlaiZephyr changed the title fix cmake error when building with -DMYSQL=ON fix cmake warning when building with -DMYSQL=ON Jan 31, 2024
@def- def- enabled auto-merge January 31, 2024 09:00
@heinrich5991
Copy link
Member

I don't get why the check fails. But it doesn't fail on master so I assume it's got something to do with this PR.

@Robyt3
Copy link
Member

Robyt3 commented Feb 5, 2024

Permalink for run results: logs_58358.zip

@rffontenelle
Copy link
Contributor

rffontenelle commented Feb 5, 2024

In ubuntu-20.04 I noticed this output:

CMake Warning:
  Value of MYSQL_CONFIG_INCLUDE_DIR contained a newline; truncating

I also noticed the version difference:

  • In ubuntu-latest: cmake 3.22.1-1ubuntu1.22.04.1
  • In ubuntu-20.04: cmake 3.16.3-1ubuntu1.20.04.1

auto-merge was automatically disabled February 10, 2024 10:01

Head branch was pushed to by a user without write access

@BlaiZephyr
Copy link
Contributor Author

status: no idea how to approach this - feel free to close if you dont want an open PR lying around

@Jupeyy
Copy link
Member

Jupeyy commented May 4, 2024

when ubuntu 24 will be added to the CIs we can also drop ubuntu 20.

see actions/runner-images#9691

@rffontenelle
Copy link
Contributor

ubuntu-24.04 now available, although it is not ubuntu-latest yet

actions/runner-images#9848

hossain666

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build warning: "Policy CMP0153 is not set: The exec_program command should not be called."
7 participants