Read workflow_search input as a boolean #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit f6b0bac we added a check for !workflow_search before using the current workflow, but with a string this always evaluates to true. This results in always searching workflows, and if enough inputs are unspecified it can find the wrong run id. Signed-off-by: Kyle Harding <kyle@balena.io>
klutchell
force-pushed
the
workflow-search-boolean
branch
from
d29478b
to
e1e0f29
Compare
dawidd6
pushed a commit
that referenced
this pull request
Feb 21, 2024
In commit f6b0bac we added a check for !workflow_search before using the current workflow, but with a string this always evaluates to true. This results in always searching workflows, and if enough inputs are unspecified it can find the wrong run id. Signed-off-by: Kyle Harding <kyle@balena.io>
dawidd6
added a commit
that referenced
this pull request
Feb 21, 2024
In commit f6b0bac we added a check for !workflow_search before using the current workflow, but with a string this always evaluates to true. This results in always searching workflows, and if enough inputs are unspecified it can find the wrong run id. Signed-off-by: Kyle Harding <kyle@balena.io> Co-authored-by: Kyle Harding <kyle@balena.io>
|
Thanks @klutchell! |
|
No problem, thank you for maintaining this project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit f6b0bac we added a check for !workflow_search before using the current workflow, but with a string this always evaluates to true.
This results in always searching workflows, and if enough inputs are unspecified it can find the wrong run id.