Follow refs when finding default property values #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves any `ref_schema` keywords (`$ref`, `$dynamicRef`,
`$recursiveRef`) when looking for `default` keywords for
`insert_property_defaults`. It follows the keyword order defined in the
vocabulary (`$ref` first, then `$dynamicRef`/`$recursiveRef` depending
on the meta schema) and searches depth-first (ie, follows a `$ref` chain
until a leaf schema before moving on to a sibling `$dynamicRef`). The
first `default` keyword found is used, meaning a `$ref` default can be
overwritten by the including schema, eg:
```json
{
"properties": {
"example": {
"$ref": "#/$defs/ref",
"default": "override!"
}
},
"$defs": {
"ref": {
"default": "overridden"
}
}
}
```
Closes: #173
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves any
ref_schemakeywords ($ref,$dynamicRef,$recursiveRef) when looking fordefaultkeywords forinsert_property_defaults. It follows the keyword order defined in the vocabulary ($reffirst, then$dynamicRef/$recursiveRefdepending on the meta schema) and searches depth-first (ie, follows a$refchain until a leaf schema before moving on to a sibling$dynamicRef). The firstdefaultkeyword found is used, meaning a$refdefault can be overwritten by the including schema, eg:{ "properties": { "example": { "$ref": "#/$defs/ref", "default": "override!" } }, "$defs": { "ref": { "default": "overridden" } } }Closes: #173