Only parse $schema during schema validation
#171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parsing the whole schema can lead to errors for malformed keyword
values, eg:
```
>> JSONSchemer.schema({ 'properties' => '' })
/Users/dharsha/repos/json_schemer/lib/json_schemer/draft202012/vocab/applicator.rb:224:in `parse': undefined method `each_with_object' for an instance of String (NoMethodError)
value.each_with_object({}) do |(property, subschema), out|
^^^^^^^^^^^^^^^^^
from /Users/dharsha/repos/json_schemer/lib/json_schemer/keyword.rb:14:in `initialize'
```
Instead, this creates a minimal parseable schema with just the `$schema`
value, if it's present and a string. That way the meta schema can be
determined as usual and then used to validate the provided schema.
Addresses: #167
This aligns the schema generation (`JSONSchemer.schema`) and schema validation (`valid_schema?` and `validate_schema`) method interfaces, so that they all take the same schema object types.
The default meta schemas don't inherit the provided options, because they're initialized with their own options and cached. To override validation-time options, they need to be passed directly to the validation methods. This is a little brittle because the validation-time options are listed separately to pull them out of the options hash. I couldn't think of a better way to split the initialization and validation options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing the whole schema can lead to errors for malformed keyword
values, eg:
Instead, this creates a minimal parseable schema with just the
$schemavalue, if it's present and a string. That way the meta schema can be
determined as usual and then used to validate the provided schema.
Addresses: #167
Also made schema validation methods more consistent with the regular validation methods:
StringandPathnamesupportoutput_format,resolve_enumerators, andaccess_mode)