Fix keyword refs #160
Merged
Fix keyword refs #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes two problems with JSON pointer refs and known keywords: - If the ref resolved to a `Keyword` object with a schema value (eg, `#/items`), `unknown_schema!` was called, which was only defined for `UnknownKeyword`. I changed the name to `parsed_schema` and defined it for all keywords, though it still feels brittle since it requires keywords to pre-parse their values into schema objects. - If the ref resolved through a `Keyword` object with a schema value (eg, `#/items/not`), `fetch` was called on the keyword's parsed schema, which wasn't defined. I settled on a `fetch` method for `Keyword` and `Schema` to find child objects by key/index. That way a keyword with a schema value will delegate `fetch` to its parsed schema object. `UnknownKeyword` also becomes less of a special case. I also added a `Schema` type check after pointer resolution to help people identify misdirected pointers. Closes: #159
davishmcclurg
force-pushed
the
keyword-ref
branch
from
52fb83f
to
8492b6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two problems with JSON pointer refs and known keywords:
If the ref resolved to a
Keywordobject with a schema value (eg,#/items),unknown_schema!was called, which was only defined forUnknownKeyword. I changed the name toparsed_schemaand defined itfor all keywords, though it still feels brittle since it requires
keywords to pre-parse their values into schema objects.
If the ref resolved through a
Keywordobject with a schema value(eg,
#/items/not),fetchwas called on the keyword's parsedschema, which wasn't defined. I settled on a
fetchmethod forKeywordandSchemato find child objects by key/index. That way akeyword with a schema value will delegate
fetchto its parsed schemaobject.
UnknownKeywordalso becomes less of a special case.I also added a
Schematype check after pointer resolution to helppeople identify misdirected pointers.
Closes: #159