Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix readDataFromParent mouseEvents Boolean to strBool #990

Conversation

tonyliving
Copy link
Contributor

readDataFromParent mouseEvents Boolean to strBool

@davidjbradshaw
Copy link
Owner

What is the reason for changing this?

@tonyliving
Copy link
Contributor Author

Boolean("false") --> ture wrong
strBool("false")-->false right

You can try to set in parent page

iframeResizer(
{
mouseEvents:false
},
document.getElementById("iframe")
)

inPageLinks.enable = undefined !== data[12] ? strBool(data[12]) : false

mouseEvents = undefined !== data[15] ? Boolean(data[15]) : mouseEvents

You can compare these two lines.What to do with boolean values

@tonyliving
Copy link
Contributor Author

@davidjbradshaw

@davidjbradshaw davidjbradshaw merged commit e302a0b into davidjbradshaw:master Feb 18, 2023
@davidjbradshaw
Copy link
Owner

Released as v4.3.4

Sorry for the delay, I have been very ill for the last year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants