Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables runtime changes of the iFrame autoResize function. #723

Merged
merged 2 commits into from Sep 24, 2019

Conversation

deBFM
Copy link
Contributor

@deBFM deBFM commented Jul 1, 2019

I have a usecase that requires runtime changes of the autoResize behavior.

The documentation of the parentIFrame.autoResize function suggests that the auto resizing behavior can be changed at runtime. Unfortunately, runtime changes do not take effect.

This PR

  • enhances the example page so that runtime changes of this property can be tested
  • fixes event handling so that runtime changes are handled as expected.

deBFM added 2 commits July 1, 2019 16:14
Signed-off-by: Dennis Kronbügel <dennis.kronbuegel@gmail.com>
This commit fixes a bug where runtime changes of the iFrame autoResize function were ignored.

Signed-off-by: Dennis Kronbügel <dennis.kronbuegel@gmail.com>
@davidjbradshaw
Copy link
Owner

Just back from a long summer break, I will try and release this in the next week or so.

@davidjbradshaw davidjbradshaw merged commit 9a67563 into davidjbradshaw:master Sep 24, 2019
@deBFM deBFM deleted the autoResizeFix branch September 26, 2019 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants