Fix ie11 support (Object.values) #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Arh, good spot, I thought I'd checked that on caniuse, but it appears not. |
|
I'll check and release this in the morning |
|
Released as v4.1.1 |
|
Thank you for this |
|
Thanks for the quick merge and release! |
|
Your latest merge doesn't seem to be working for me - the iframe no longer resizes in any browser... Also, I believe there are few out-of-date files in the repository. |
|
Any error message? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like ie11 doesn't support
Object.values. I've replaced the 2 instances of this with code that will run in ie11.My branch includes changes from running
npm run build, let me know if you'd rather me commit the changes without the build changes, or if there are any other changes you want me to make.