index.d.ts: Expose the flush method on the return type #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to this PR: #33 |
| @@ -11,7 +11,9 @@ declare namespace PinoSeq { | |||
| onError?: (e: Error) => void; | |||
| } | |||
|
|
|||
| function createStream(config: PinoSeq.SeqConfig): Writable; | |||
| function createStream(config: PinoSeq.SeqConfig): Writable & { _logger: seq.Logger; flushBuffer: () => void }; | |||
There was a problem hiding this comment.
Will this compile? I'm not sure where the seq.Logger type is coming from.
There was a problem hiding this comment.
Unfortunately, flushBuffer is not very useful. It pushes the log events to seq-logging but they can still be buffered there.
There was a problem hiding this comment.
yes, I used these comments locally (in my repo):
/** The underlying seq.Logger instance */
_logger: seq.Logger
/** Fire and forget async flush of the buffer, use _logger.flush() for a promise */
flushBuffer: () => void
|
@richard-stafflink would something like #37 get the job done? |
Yes, thanks @liammclennan |
|
@richard-stafflink #37 is merged and published as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS lambdas will halt/freeze the Node process as soon as a result is returned.
So, in order to not lose log entries, the lambda should flush logs just before returning a result