fix(ingest): DataProcessInstance.emit_process_end() ignored start_timestamp_millis #10539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The high-level method DataProcessInstance.emit_process_end() actually ignores start_timestamp_millis, which can be passed further to calculate durationMillis instead of using None. This change makes emitter use this argument and save durationMillis.
github-actions
bot
added
ingestion
obaltian
changed the title
hsheth2
approved these changes
May 22, 2024
hsheth2
added
the
merge-pending-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The high-level method DataProcessInstance.emit_process_end() actually ignores start_timestamp_millis, which can be passed further to calculate durationMillis instead of using None. This change makes emitter use this argument and save durationMillis.
Checklist