Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(roles): update privileges #10528

Merged
merged 24 commits into from
Jun 5, 2024
Merged

doc(roles): update privileges #10528

merged 24 commits into from
Jun 5, 2024

Conversation

ksrinath
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added docs Issues and Improvements to docs community-contribution PR or Issue raised by member(s) of DataHub Community labels May 17, 2024
@ksrinath ksrinath marked this pull request as ready for review May 20, 2024 09:11
eboneil
eboneil reviewed May 21, 2024
View reviewed changes
Copy link
Collaborator

@eboneil eboneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks pretty good, though I did notice that this page is out of sync with this page: https://datahubproject.io/docs/authorization/policies/
i.e., there are policies missing on one that are on the other. Can we get them into parity with this PR as well, since my customers check both places for guidance?

docs/authorization/roles.md Outdated Show resolved Hide resolved
docs/authorization/roles.md Outdated Show resolved Hide resolved
@ksrinath ksrinath marked this pull request as draft May 28, 2024 07:48
@ksrinath ksrinath marked this pull request as ready for review May 28, 2024 13:24
eboneil
eboneil approved these changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@eboneil eboneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@anshbansal anshbansal merged commit 90febde into datahub-project:master Jun 5, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eboneil eboneil eboneil approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community docs Issues and Improvements to docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ksrinath @eboneil @anshbansal