Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest/protobuf): support korean description #10517

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

wngus606
Copy link
Contributor

PR Point

  • For this issue, I think we can use UTF-8 because it seems to have been resolved. Is there any other problem?

  • AS-IS
    스크린샷 2024-05-16 15 33 07

  • TO-BE
    스크린샷 2024-05-16 15 36 00

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels May 16, 2024
@wngus606
Copy link
Contributor Author

PTAL
@david-leifker

@wngus606 wngus606 changed the title fix(protobuf): support korean description fix(ingest/protobuf): support korean description May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant