refactor(ingest): defer ctx.graph initialization #10504
Merged
+121
−113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
5 tasks
treff7es
approved these changes
May 21, 2024
| try: | ||
| return self.get(key) | ||
| except Exception: | ||
| return None |
There was a problem hiding this comment.
Isn't there a nicer way to get None instead of a silently caught exception?
Do we care about the exception or is it fine to drop silently?
There was a problem hiding this comment.
in this case, we don't care about the exception
| raise IgnorableError( | ||
| f"Datahub ingestion reporter will be disabled because sink type {sink_config_holder.type} is not supported" | ||
| f"Datahub ingestion reporter will be disabled because sink type {type(sink)} is not supported" |
There was a problem hiding this comment.
It looks a bit weird we use a hardwired list for this, and not the sink has some property which can tell if it supports reporter or not
There was a problem hiding this comment.
yeah I don't really like the way this is set up either, but don't want to boil the ocean right now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist