Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(query): Reopen keep-alive for MySQL & rollback socket2 to 0.4 #10642

Merged
merged 2 commits into from
Mar 19, 2023

Conversation

yufan022
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

Closes #10641

@vercel
Copy link

vercel bot commented Mar 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
databend ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 19, 2023 at 1:44AM (UTC)

@mergify mergify bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Mar 18, 2023
@sundy-li
Copy link
Member

cc @TCeason It's strange that the test result contain grant to system.one.

[SQL] SHOW GRANTS FOR 'test-grant'@'localhost'
[Diff] (-expected|+actual)
    GRANT ALL ON 'default'.'default'.* TO 'test-grant'@'localhost'
    GRANT SELECT ON 'default'.'db01'.* TO 'test-grant'@'localhost'
-   GRANT SELECT ON 'default'.'db01'.'tb1' TO 'test-grant'@'localhost'
-   GRANT SELECT ON 'default'.'system'.'one' TO 'test-grant'@'localhost'
+   GRANT SELECT ON 'default'.'db01'.'tb1' TO 'test-grant'@'localhost'
at tests/sqllogictests/suites/base/05_ddl/05_0006_ddl_grant_privilege:49

@BohuTANG
Copy link
Member

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Mar 19, 2023

update

✅ Branch has been successfully updated

Copy link
Member

@dantengsky dantengsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 0f7e24b into datafuselabs:main Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Reopen tcp keep-alive for MySQL
5 participants