Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tiles to use chart action icons in footer #4205

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

juliawu
Copy link
Contributor

@juliawu juliawu commented May 7, 2024

Switches our chart tiles to using icons in chart footers for the following functions: (1) downloading svg or csv, (2) link to visualization tool, (3) embed the chart as a web component, (4) provide feedback on the chart if on the explore page

Sample behavior:

Screen.Recording.2024-05-08.at.1.41.27.PM.mov

In particular, changes include:

  • renaming chartEmbed to chart download to prevent confusion with embedding a web component
  • New folder for the new modals
  • A new chart embed modal that gives users the code for the web component version of the tile
  • A new NL feedback modal
  • Standardizing icons to using material icons instead of material symbols (reduces css to download)
  • Web components now have a "Powered by Google's Data Commons" branding line

Visualization tools still use the old styling:
Screenshot 2024-05-08 at 3 09 35 PM

Web components use the new icons:
Screenshot 2024-05-08 at 1 47 51 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant