-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated loading indicator on ranking, line, scatter, and bar chart #4184
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
return ( | ||
<div | ||
className={"ranking-list " + ASYNC_ELEMENT_CLASS} | ||
ref={props.forwardRef} | ||
> | ||
<div className="ranking-header-section"> | ||
<h4>{props.title}</h4> | ||
<h4> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: consider extracting this loading header into a shared component to be used by chart_tile.tsx, ranking_tile.tsx, and here to make sure it is always consistent if changes are made in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Screenshots
Explore page
Full page loading
Bar
Line
Ranking
Scatter
Visualization tool
Loading
Line
Map / Ranking
Scatter