Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Int64 to header type injection #819

Merged
merged 1 commit into from Feb 19, 2024
Merged

Add Int64 to header type injection #819

merged 1 commit into from Feb 19, 2024

Conversation

hectorcast-db
Copy link
Contributor

Changes

Add Int64 to header type injection

Tests

  • make test passing
  • make fmt applied
  • relevant integration tests applied

@hectorcast-db hectorcast-db marked this pull request as ready for review February 15, 2024 15:15
@codecov-commenter
Copy link

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (99aeb90) 18.69% compared to head (c88f31a) 18.68%.

Files Patch % Lines
httpclient/response.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #819      +/-   ##
==========================================
- Coverage   18.69%   18.68%   -0.01%     
==========================================
  Files         117      117              
  Lines       21653    21659       +6     
==========================================
  Hits         4047     4047              
- Misses      17355    17361       +6     
  Partials      251      251              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@edwardfeng-db edwardfeng-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hectorcast-db hectorcast-db added this pull request to the merge queue Feb 19, 2024
Merged via the queue into main with commit 6846045 Feb 19, 2024
4 checks passed
@hectorcast-db hectorcast-db deleted the fix-type branch February 19, 2024 09:02
hectorcast-db added a commit that referenced this pull request Feb 19, 2024
Internal Changes:

* Add helper function to get header fields ([#822](#822)).
* Add Int64 to header type injection ([#819](#819)).

API Changes:

 * Changed `Update` method for [w.LakehouseMonitors](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#LakehouseMonitorsAPI) workspace-level service with new required argument order.
 * Added [w.OnlineTables](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#OnlineTablesAPI) workspace-level service.
 * Removed `AssetsDir` field for [catalog.UpdateMonitor](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#UpdateMonitor).
 * Added [catalog.ContinuousUpdateStatus](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#ContinuousUpdateStatus).
 * Added [catalog.DeleteOnlineTableRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#DeleteOnlineTableRequest).
 * Added [catalog.FailedStatus](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#FailedStatus).
 * Added [catalog.GetOnlineTableRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#GetOnlineTableRequest).
 * Added [catalog.OnlineTable](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#OnlineTable).
 * Added [catalog.OnlineTableSpec](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#OnlineTableSpec).
 * Added [catalog.OnlineTableState](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#OnlineTableState).
 * Added [catalog.OnlineTableStatus](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#OnlineTableStatus).
 * Added [catalog.PipelineProgress](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#PipelineProgress).
 * Added [catalog.ProvisioningStatus](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#ProvisioningStatus).
 * Added [catalog.TriggeredUpdateStatus](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#TriggeredUpdateStatus).
 * Added [catalog.ViewData](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#ViewData).
 * Added `ContentLength` field for [files.DownloadResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/files#DownloadResponse).
 * Added `ContentType` field for [files.DownloadResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/files#DownloadResponse).
 * Added `LastModified` field for [files.DownloadResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/files#DownloadResponse).
 * Changed `LastModified` field for [files.GetMetadataResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/files#GetMetadataResponse) to [files.LastModifiedHttpDate](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/files#LastModifiedHttpDate).
 * Added [files.LastModifiedHttpDate](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/files#LastModifiedHttpDate).
 * Removed `Config` field for [serving.ExternalModel](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ExternalModel).
 * Added `Ai21labsConfig` field for [serving.ExternalModel](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ExternalModel).
 * Added `AnthropicConfig` field for [serving.ExternalModel](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ExternalModel).
 * Added `AwsBedrockConfig` field for [serving.ExternalModel](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ExternalModel).
 * Added `CohereConfig` field for [serving.ExternalModel](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ExternalModel).
 * Added `DatabricksModelServingConfig` field for [serving.ExternalModel](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ExternalModel).
 * Added `OpenaiConfig` field for [serving.ExternalModel](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ExternalModel).
 * Added `PalmConfig` field for [serving.ExternalModel](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ExternalModel).
 * Removed [serving.ExternalModelConfig](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ExternalModelConfig).
 * Added `MaxProvisionedThroughput` field for [serving.ServedEntityInput](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ServedEntityInput).
 * Added `MinProvisionedThroughput` field for [serving.ServedEntityInput](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ServedEntityInput).
 * Added `MaxProvisionedThroughput` field for [serving.ServedEntityOutput](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ServedEntityOutput).
 * Added `MinProvisionedThroughput` field for [serving.ServedEntityOutput](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ServedEntityOutput).

OpenAPI SHA: cdd76a98a4fca7008572b3a94427566dd286c63b, Date: 2024-02-19
@hectorcast-db hectorcast-db mentioned this pull request Feb 19, 2024
github-merge-queue bot pushed a commit that referenced this pull request Feb 19, 2024
Internal Changes:

* Add helper function to get header fields
([#822](#822)).
* Add Int64 to header type injection
([#819](#819)).

API Changes:

* Changed `Update` method for
[w.LakehouseMonitors](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#LakehouseMonitorsAPI)
workspace-level service with new required argument order.
* Added
[w.OnlineTables](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#OnlineTablesAPI)
workspace-level service.
* Removed `AssetsDir` field for
[catalog.UpdateMonitor](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#UpdateMonitor).
* Added
[catalog.ContinuousUpdateStatus](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#ContinuousUpdateStatus).
* Added
[catalog.DeleteOnlineTableRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#DeleteOnlineTableRequest).
* Added
[catalog.FailedStatus](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#FailedStatus).
* Added
[catalog.GetOnlineTableRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#GetOnlineTableRequest).
* Added
[catalog.OnlineTable](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#OnlineTable).
* Added
[catalog.OnlineTableSpec](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#OnlineTableSpec).
* Added
[catalog.OnlineTableState](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#OnlineTableState).
* Added
[catalog.OnlineTableStatus](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#OnlineTableStatus).
* Added
[catalog.PipelineProgress](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#PipelineProgress).
* Added
[catalog.ProvisioningStatus](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#ProvisioningStatus).
* Added
[catalog.TriggeredUpdateStatus](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#TriggeredUpdateStatus).
* Added
[catalog.ViewData](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#ViewData).
* Added `ContentLength` field for
[files.DownloadResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/files#DownloadResponse).
* Added `ContentType` field for
[files.DownloadResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/files#DownloadResponse).
* Added `LastModified` field for
[files.DownloadResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/files#DownloadResponse).
* Changed `LastModified` field for
[files.GetMetadataResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/files#GetMetadataResponse)
to
[files.LastModifiedHttpDate](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/files#LastModifiedHttpDate).
* Added
[files.LastModifiedHttpDate](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/files#LastModifiedHttpDate).
* Removed `Config` field for
[serving.ExternalModel](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ExternalModel).
* Added `Ai21labsConfig` field for
[serving.ExternalModel](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ExternalModel).
* Added `AnthropicConfig` field for
[serving.ExternalModel](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ExternalModel).
* Added `AwsBedrockConfig` field for
[serving.ExternalModel](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ExternalModel).
* Added `CohereConfig` field for
[serving.ExternalModel](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ExternalModel).
* Added `DatabricksModelServingConfig` field for
[serving.ExternalModel](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ExternalModel).
* Added `OpenaiConfig` field for
[serving.ExternalModel](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ExternalModel).
* Added `PalmConfig` field for
[serving.ExternalModel](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ExternalModel).
* Removed
[serving.ExternalModelConfig](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ExternalModelConfig).
* Added `MaxProvisionedThroughput` field for
[serving.ServedEntityInput](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ServedEntityInput).
* Added `MinProvisionedThroughput` field for
[serving.ServedEntityInput](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ServedEntityInput).
* Added `MaxProvisionedThroughput` field for
[serving.ServedEntityOutput](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ServedEntityOutput).
* Added `MinProvisionedThroughput` field for
[serving.ServedEntityOutput](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ServedEntityOutput).

OpenAPI SHA: cdd76a98a4fca7008572b3a94427566dd286c63b, Date: 2024-02-19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants