Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match pandas reverting apply deprecation #10531

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Conversation

jrbourbeau
Copy link
Member

pandas recently reverted this deprecations (xref pandas-dev/pandas#55189). We do the same thing here to match behavior with pandas and fix test that are currently failing in CI

cc @phofl

@jrbourbeau
Copy link
Member Author

Okay, it looks like

FAILED dask/dataframe/tests/test_merge_column_and_index.py::test_merge_column_with_nulls[None]
FAILED dask/dataframe/tests/test_merge_column_and_index.py::test_merge_column_with_nulls[4]
FAILED dask/dataframe/tests/test_multi.py::test_join_by_index_patterns[disk-left]
FAILED dask/dataframe/tests/test_multi.py::test_join_by_index_patterns[tasks-right]
FAILED dask/dataframe/tests/test_multi.py::test_join_by_index_patterns[tasks-left]
FAILED dask/dataframe/tests/test_multi.py::test_join_by_index_patterns[disk-right]

are still failing on pandas=2.1.1 (I thought there was just an upstream issue only on 2.1.0). Let's go ahead and continue to skip these tests for now. This definitely isn't ideal, but also isn't any worse than what we currently have on main. @phofl do you know why these are still failing? (xref #10488)

@jrbourbeau
Copy link
Member Author

I'll go ahead and merge this PR in as I think it's pretty uncontroversial and also unblocks CI for others. I'm happy to follow-up if folks have feedback

@jrbourbeau jrbourbeau merged commit 2d1451d into dask:main Sep 25, 2023
24 checks passed
@jrbourbeau jrbourbeau deleted the pandas-2.1.1 branch September 25, 2023 21:12
@phofl
Copy link
Collaborator

phofl commented Sep 25, 2023

change is good, the deprecation was bad and shouldn't have been merged

Not clue why the merge tests are still broken, will take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants