New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up after renaming the be channel to main. #115
Merged
devoncarew
merged 3 commits into
main
from
sortie-clean-up-after-renaming-the-be-channel-to-main
Jan 9, 2024
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll want a changelog entry for this, and will need to bump the action's version as well.
Thinking through how users will see this change:
Is this change essentially dropping support for sdks before some version? Or, just for
main
channel sdks before some version? We probably don't need to support many previous versions for those sdks.Can you update the changelog w/ an entry, and in that entry mention for which sdk version we first started writing artifacts into the
main
bucket?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main channel was only ever 'supported' for latest. There is no support in here for pinning a particular hash or an older SDK version.
Anyone that uses the old action before 1.5.0 (or what it was) will now be stuck on that last be release as of today, and anyone on that version or newer will use the main channel as of today (the compat logic I'm removing here automatically switched them together).
I'll add some changelog stuff and bump the version, this was just to get started while it was on my mind :)
Note that I am starting to feel we really should drop support for the raw flavor. The main channel builds is not a supported product in any way and the binaries aren't signed. I may even decide to store these artifacts elsewhere in the future to guard the release bucket even more closely. I'll also want to discontinue the whole raw/signed flavor concept, since people should not really be poking in there and I need to change the layout for unrelated reasons, and it'll massively simplify this action. But that's a discussion for another day.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, thanks for the clarification re: how breaking this is; ~sounds like this will not be a breaking change. I think either a patch version rev or a minor version would be appropriate.
I think the simplifications to this action would be welcome. We probably want to open an issue on this repo in order to discuss, get feedback, and help any user that might be impacted plan alternatives.