Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debugging issues around specifying the latest patch release #108

Merged
merged 12 commits into from Oct 11, 2023
Merged

debugging issues around specifying the latest patch release #108

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
6774c4c
debugging issues around specifying the latest patch release
devoncarew Sep 29, 2023
836f561
exitCode as a field
devoncarew Sep 29, 2023
5176c50
handle converting '3' to '3.0'
devoncarew Sep 29, 2023
d125707
wrap sdk values in quotes
devoncarew Sep 29, 2023
1167d44
address process exit code issue
devoncarew Oct 7, 2023
0db74b2
restore int => double promotion code
devoncarew Oct 7, 2023
27c7643
review comments
devoncarew Oct 10, 2023
b6470d4
comments
devoncarew Oct 10, 2023
0a35985
set the process.exitCode value
devoncarew Oct 10, 2023
0946d39
re-test process.exitCode
devoncarew Oct 10, 2023
cfcd30e
remove temporary test
devoncarew Oct 10, 2023
40451ff
Update build.yml
devoncarew Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Expand Up @@ -15,7 +15,7 @@ jobs:
- uses: actions/checkout@v3
- uses: ./
with:
sdk: dev
sdk: 'dev'
devoncarew marked this conversation as resolved.
Show resolved Hide resolved
- run: dart pub get
- run: dart analyze --fatal-infos
- run: dart tool/sig.dart --verify
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/dart.yml
View file
Open in desktop
Expand Up @@ -21,7 +21,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
sdk: [2.12.4, stable, beta, dev]
sdk: ['2.12.4', 'stable', 'beta', 'dev']
devoncarew marked this conversation as resolved.
Show resolved Hide resolved
fail-fast: false
steps:
- uses: actions/checkout@v3
Expand All @@ -42,7 +42,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
sdk: [dev, main]
sdk: ['dev', 'main']
flavor: [raw]
fail-fast: false
steps:
Expand Down Expand Up @@ -75,7 +75,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
sdk: [2.12.0-29.10.beta]
sdk: ['2.12.0-29.10.beta']
fail-fast: false
steps:
- uses: actions/checkout@v3
Expand All @@ -94,7 +94,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
sdk: [2.19, 3.1]
sdk: ['2.19', 3.0, '3.1']
fail-fast: false
steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Expand Up @@ -91,7 +91,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
sdk: [3.1, stable, beta, dev]
sdk: ['3.1', 'stable', 'beta']
steps:
- uses: actions/checkout@v3
- uses: dart-lang/setup-dart@v1
Expand Down
2 changes: 1 addition & 1 deletion action.yml
View file
Open in desktop
Expand Up @@ -7,7 +7,7 @@ inputs:
sdk:
description: >-
This can be either the channel to install (i.e., 'stable', 'beta', 'dev'),
an SDK release version (i.e., `2.19`, `3.1`), or a specific SDK version
an SDK release version (i.e., '2.19', '3.1'), or a specific SDK version
(i.e, '2.19.1', '3.0.0-1.4.beta').
required: false
default: "stable"
Expand Down