Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support renaming the be channel to main. #102

Merged
merged 4 commits into from Sep 13, 2023
Merged

Support renaming the be channel to main. #102

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1d5b453
Support renaming the be channel to main.
sortie Sep 8, 2023
1b8da1b
recompile action
devoncarew Sep 12, 2023
99349ea
Add changelog entry for the be -> main rename.
sortie Sep 13, 2023
3aa4da5
update todo and rev changelog version
devoncarew Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
141 changes: 56 additions & 85 deletions dist/main.cjs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/sig.txt
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 9 additions & 3 deletions lib/main.dart
View file
Open in desktop
Expand Up @@ -51,9 +51,15 @@ void main(List<String> args) async {
version =
raw ? 'latest' : (await latestPublishedVersion(channel, flavor));
} else if (sdk == 'main') {
channel = 'be';
version =
raw ? 'latest' : (await latestPublishedVersion(channel, flavor));
// TODO(b/299435467): Temporary forward compatibility that
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you replace this buganizer reference with a github issue ref?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could do that though the issue is just for myself to track the cleanups -- our team uses buganizer internally rather than github issues to manage our daily tasks and I never look at my github issues in practice. There's literally no content in the bug besides the title which is repeated here -- it just serves as an unique identifier that I can code search for to find all the relevant code locations that needs fixing. Do you feel I should file an issue in this repo about this cleanup instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha. My main concern was that users w/o access to the bug would have some mystery about what it was tracking. I re-worded this comment slightly to clarify things (the buganizer issue just tracks the channel rename).

// automatically migrates users when the be channel is renamed to main.
try {
channel = 'main';
await latestPublishedVersion(channel, flavor);
} catch (_) {
channel = 'be';
}
version = 'latest';
} else {
version = sdk;

Expand Down