refactor CI testing of dart-services #2719
Conversation
| runs-on: ubuntu-latest | ||
| defaults: | ||
| run: | ||
| working-directory: pkgs/dart_services/ | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| sdk: [stable, beta, main] | ||
| sdk: [stable, beta, master] # main |
There was a problem hiding this comment.
subosito/flutter-action doesn't seem to support main
There was a problem hiding this comment.
|
With this PR, both We now run We're working around an issue with the flutter sdk's In addition, it doesn't look like |
|
|
| Map<String, dynamic> _callFlutterVersion() { | ||
| // Note that we try twice here as the 'flutter --version --machine' command | ||
| // can (erroneously) emit non-json text to stdout (for example, an initial | ||
| // analytics disclaimer). |
There was a problem hiding this comment.
Maybe we need to run flutter config --no-analytics and dart --disable-analytics somewhere?
There was a problem hiding this comment.
flutter config --no-analytics is a good call. But flutter --version --machine - which emits json - should never emit cruft to stdout; the output needs to be parseable.
|
Note that there is a test failure for |
This PR has grown a bit but includes some important fixes.
Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.