Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dangerID to gitlab createComment api #1395

Merged
merged 2 commits into from Jul 31, 2023
Merged

Add dangerID to gitlab createComment api #1395

merged 2 commits into from Jul 31, 2023

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Jul 30, 2023

Alternative fix #1381 based on review notes:

Fixes #1380 (comment)
Replaces #1380

@glensc glensc marked this pull request as ready for review July 30, 2023 18:10
@orta
Copy link
Member

orta commented Jul 31, 2023

I see, so the issue was that the args passed into it didn't match where it is used somewhere. It doens't match how the GitHub platform works: createComment: (comment: string) => api.postPRComment(comment), but I'll assume that this is right as a few folks agree

@orta orta merged commit 8bba64f into danger:main Jul 31, 2023
1 of 2 checks passed
@glensc glensc deleted the 1381-fix branch July 31, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Inline comments deleted in GitLab pipeline
2 participants