Skip to content

Commit

Permalink
Merge pull request #1395 from glensc/1381-fix
Browse files Browse the repository at this point in the history
Add dangerID to gitlab createComment api
  • Loading branch information
orta committed Jul 31, 2023
2 parents 26387bc + 8c2847e commit 8bba64f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Expand Up @@ -15,6 +15,7 @@
## Main

<!-- Your comment below this -->
- Add dangerID to gitlab createComment api #1395 [@glensc]
<!-- Your comment above this -->

## 11.2.7
Expand Down
4 changes: 2 additions & 2 deletions source/platforms/GitLab.ts
Expand Up @@ -114,7 +114,7 @@ class GitLab implements Platform {
newOrUpdatedNote = await this.api.updateMergeRequestNote(existingNote.id, newComment)
} else {
// create a new comment
newOrUpdatedNote = await this.createComment(newComment)
newOrUpdatedNote = await this.createComment(dangerID, newComment)
}

// create URL from note
Expand Down Expand Up @@ -145,7 +145,7 @@ class GitLab implements Platform {
}
}

createComment = async (comment: string): Promise<GitLabNote> => {
createComment = async (_dangerID: string, comment: string): Promise<GitLabNote> => {
d("createComment", { comment })
if (useThreads()) {
return (await this.api.createMergeRequestDiscussion(comment)).notes[0]
Expand Down

0 comments on commit 8bba64f

Please sign in to comment.