Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade Ruff to 0.3.0 #20249

Merged
merged 2 commits into from Mar 5, 2024
Merged

chore: Upgrade Ruff to 0.3.0 #20249

merged 2 commits into from Mar 5, 2024

Conversation

PedramNavid
Copy link
Contributor

Summary & Motivation

Upgrades ruff to 0.3.0. Main change is ellipses now are formatted on a single line: astral-sh/ruff#5822

How I Tested These Changes

bk

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @PedramNavid and the rest of your teammates on Graphite Graphite

Copy link

github-actions bot commented Mar 4, 2024

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-n43yeu4hf-elementl.vercel.app
https://pdrm-ruff-0-3-0.dagster.dagster-docs.io

Direct link to changed pages:

Copy link
Member

@rexledesma rexledesma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have an internal PR ready as well before landing this change. Otherwise, looks good

@@ -25,7 +25,7 @@ unannotated_pyright:
python scripts/run-pyright.py --unannotated

ruff:
-ruff --fix .
-ruff check --fix .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A breadcrumb for other reviewers: ruff <path> was deprecated in favor of ruff check <path>. See https://github.com/astral-sh/ruff/releases/tag/v0.3.0.

@PedramNavid PedramNavid merged commit 2623f31 into master Mar 5, 2024
2 checks passed
@PedramNavid PedramNavid deleted the pdrm/ruff-0.3.0 branch March 5, 2024 05:45
PedramNavid added a commit that referenced this pull request Mar 28, 2024
## Summary & Motivation

Upgrades ruff to 0.3.0. Main change is ellipses now are formatted on a single line: astral-sh/ruff#5822

## How I Tested These Changes

bk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants