track stable function call hash + more attrs #7321
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moved
telemetry/graphql.go
tocore/telemetry.go
so it can integrate withQuery
to get necessary module metadatadagger.io/dag.digest.stable
is a Call's 'stable digest'. This digest can be used to compare performance of the same Call across different inputs over time. This calculation involves simply recursing through a call and removing any embedded Calls passed as arguments.dagger.io/dag.caller.type
indicates whether the span comes from a direct user call, a call from a module, or an internal call. We can use this to identify the top-level calls for browsing (type == direct).various attributes (name, ref, digest) for identifying a Call's module have been added, though they might be of limited utility at the moment (see large TODO comment).
All these attribute names are a bit of a mess, this might be a good time to bikeshed them