Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix precision error on voronoi.neighbors #138

Merged
merged 2 commits into from Mar 4, 2023
Merged

fix precision error on voronoi.neighbors #138

merged 2 commits into from Mar 4, 2023

Conversation

Fil
Copy link
Member

@Fil Fil commented Mar 2, 2023 •
edited

closes #137

Note that the test

d3-delaunay/test/voronoi-test.js

Line 54 in 2196b80

it("voronoi neighbors are clipped", () => {
was in the same situation (a point completely in the corner), and was testing the wrong result 😰

fix built at https://observablehq.com/@d3/voronoi-neighbors-137

cc: @UnluckyNinja

@Fil Fil requested a review from mbostock March 2, 2023 13:58
@UnluckyNinja UnluckyNinja mentioned this pull request Mar 4, 2023
Closed
mbostock
mbostock approved these changes Mar 4, 2023
View reviewed changes
Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I improved the formatting. 😬 I wish I knew how to implement this robustly like delaunator does…

@Fil Fil merged commit 9caef5c into main Mar 4, 2023
@Fil Fil deleted the fil/fix-137 branch March 4, 2023 16:26
@Fil Fil mentioned this pull request Mar 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbostock mbostock mbostock approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edges that both sides are clipped sometimes will not be identified as voronoi neighbor
2 participants
@Fil @mbostock