Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failures for Node.js 18.17 and 20.x #37

Closed
MikeMcC399 opened this issue Aug 1, 2023 · 3 comments
Closed

Test failures for Node.js 18.17 and 20.x #37

MikeMcC399 opened this issue Aug 1, 2023 · 3 comments
Labels

Comments

@MikeMcC399
Copy link

MikeMcC399 commented Aug 1, 2023

Version:
@cypress/request@2.88.12
@cypress/request@3.0.0
@cypress/request@3.0.1

yarn install
yarn test

is successful for Node.js 18.16.1 and fails for 18.17.1 & 20.7.0 running on Ubuntu 22.04.3 LTS.

Node.js 18.16.1

runs successfully (with some warnings), tested locally, on Node.js 18.16.1:

Suites:   ​54 passed​, ​54 of 54 completed​
Asserts:  ​​​1500 passed​, ​of 1500​

Node.js 18.17.0 18.17.1 (LTS)

fails tested locally, on Node.js 18.17.1:

Suites:   ​1 failed​, ​53 passed​, ​54 of 54 completed​
Asserts:  ​​​1 failed​, ​1478 passed​, ​of 1479​

Node.js 20.5.0, 20.5.1 20.6.1 20.7.0

fails tested locally, on Node.js 20.7.0:

Suites:   ​2 failed​, ​52 passed​, ​54 of 54 completed​
Asserts:  ​​​3 failed​, ​1480 passed​, ​of 1483​

Edit: Updated and retested with @cypress/request@3.0.0
Updated and retested with @cypress/request@3.0.1. Node.js 16 results removed, since this version is now end-of-life.

@MikeMcC399
Copy link
Author

Update:

yarn test is successful on Node.js 18.16.0 & 18.16.1
yarn test fails on Node.js 18.17.0

@MikeMcC399 MikeMcC399 changed the title Test failures for Node.js 18 and 20 Test failures for Node.js 18.17 and 20.x Aug 3, 2023
@MikeMcC399
Copy link
Author

Updated and retested with @cypress/request@3.0.1. Node.js 16 results removed, since this version is now end-of-life.

@MikeMcC399 MikeMcC399 mentioned this issue Oct 5, 2023
3 tasks
@MikeMcC399
Copy link
Author

yarn test passes with Node.js LTS 18.18.1

Closing this issue.

Test compatibility with Node.js 20 should be a separate issue for clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants