fix(deps): update dependency electron-context-menu to version .x 🌟 #8180
+17
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
|
See the guidelines for reviewing dependency updates for info on how to review dependency update PRs. |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
jennifer-shehane
approved these changes
Aug 5, 2020
There was a problem hiding this comment.
- This drops support for anything below Electron 8
- This fixes a potential issue in Electron 9 (which we're about to upgrade to).
- I manually tested, the context-menu works fine, it actually adds a 'Search with Google' option when highlighting text. 🤷♂️
Before
After
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
0.15.1->2.2.0Release Notes
sindresorhus/electron-context-menu
v2.2.0Compare Source
menuoption function (#111)c2d5551v2.1.0Compare Source
a539dc4dff7d88v2.0.1Compare Source
0436235v2.0.0Compare Source
Breaking
Correct Automaticallymenu item01f7b74It didn’t work like expected. It should have enabled auto-correction, but there’s no way to do that in Electron. Instead, it just corrected the first word, which is weird and also not very useful.
v1.1.0Compare Source
2547936Can be useful when, for example, used with React.
v1.0.0Compare Source
Breaking
4de32a9It should still work with older Electron versions, but I cannot guarantee it will going forward.
Improvements
71c5d2eshowSaveImageoption (#100)2f1bae0v0.16.0Compare Source
Cut,Copy, andPasteitems296ae9cWebContentstobrowserWindowTypeScript type (#90)1410532v0.15.2Compare Source
26938e1Renovate configuration
📅 Schedule: "before 3am on the first day of the month" in timezone America/New_York.
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by WhiteSource Renovate. View repository job log here.