misc: Update response-middleware.ts cookie expiration date

[jj497]

• Addressed in #29269.
• Closes 29268.

Additional details

Steps to test

How has the user experience changed?

PR Tasks

• Have tests been added/updated?
• Has a PR for user-facing changes been opened in cypress-documentation?
• Have API changes been updated in the type definitions?

[CLAassistant]

All committers have signed the CLA.

[cypress-app-bot]

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.

[jennifer-shehane]

@jj497 We'll need a reproduction of the original issue this is resolving as well as a test demonstrating the issue this is resolving before accepting.

[jj497]

Attached is a screenshot of the failure in the Cypress test suite with the __cypress.initial cookie. As you can see it has the 'athena' domain and comes back with an expired value of '1970-01-01' on the document and the error "You session has timed out....Please login again."
Also attached is another screenshot of success on the same browser, but a different tab. The complete.esp document does not contain the __cypress.intitial cookie and login proceeds as expected.

Because the login is on a 3rd party partner (athena) I can't reproduce the issue myself on our own servers but I hope the attached screenshots are sufficient evidence of the issue.

[jennifer-shehane]

@jj497 You'll need to also sign our CLA. Could you sign that?

[jj497]

@jj497 You'll need to also sign our CLA. Could you sign that?

complete!

[jj497]

@jennifer-shehane - this PR accidentally closed when I resynced the fork. Could you please help me reopen it?
My changes are here: https://github.com/jj497/cypress/blob/patch-1

[jennifer-shehane]

@jj497 Reopened

[jennifer-shehane]

@jj497 We'll still need a test that we can run that shows the bug this is fixing. We cannot accept this otherwise. Setting the cookie to a future date has other implications that will break other parts of the codebase.

[jennifer-shehane]

Closing since the undesired behavior cannot be confirmed. This would not be a passive change to change this as well.