fix: Encode fileServerFolder to fix #25839

[Zzet-Z]

• Closes [ERR_INVALID_CHAR]: Invalid character in header content ["x-cypress-file-path"] #25839

Additional details

When there are invalid header characters in a test folder path (such as Chinese characters), setting the x-cypress-file-path header fails. This PR will encode the file path header value to solve the issue and decode it in server-base.ts.

Steps to test

• Create a project that is under a folder that contains character not allowed in a header.
• Run a test that cy.visits a file served from the local file server
• Verify the visit succeeds

How has the user experience changed?

The Invalid character in header content ["x- cypress-file-path"] error is no longer thrown.

PR Tasks

• Have tests been added/updated?
• [NA] Has a PR for user-facing changes been opened in cypress-documentation?
• [NA] Have API changes been updated in the type definitions?

[cypress-app-bot]

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.

[jennifer-shehane]

Thanks for the contribution! Could you add a test around this behavior? We'll need a test in order to merge the fix.

[Zzet-Z]

@jennifer-shehane
i'd be happy to do that，and I added a new unit test case, but since this issue will only occur in Ubuntu, I just can write a passing case. Is this okay?

[Zzet-Z]

@jennifer-shehane Thanks for your review！
Sorry，I hit the Unassign button by mistake😖.
This is my first time making an open source contribution. I have checked many related documents on GitHub, but I am still a little confused about the current process. Is there anything else that I need to deal with now? Looking forward to your help.

Dismissing previous review around added test

[Zzet-Z]

@jennifer-shehane I'm a bit confused right now, sorry. Is there anything else need me to do, or just wait for you to verify and initiate the merge?

[jennifer-shehane]

@Zzet-Z Just waiting til next sprint to see if I can assign some more eyes to review this.

[Zzet-Z]

@Zzet-Z Just waiting til next sprint to see if I can assign some more eyes to review this.

OK thx！

[jennifer-shehane]

@Zzet-Z There appear to be some failing tests with this change: https://app.circleci.com/pipelines/github/cypress-io/cypress/61086/workflows/6745104d-7a56-4c94-a750-d7c5a415b06e/jobs/2539954

[Zzet-Z]

@Zzet-Z There appear to be some failing tests with this change: https://app.circleci.com/pipelines/github/cypress-io/cypress/61086/workflows/6745104d-7a56-4c94-a750-d7c5a415b06e/jobs/2539954

@jennifer-shehane Oh, that's a problem, and I found some other problems and dealt with them. The local operation passed these tests. Could you please help me run the integration test again if it is convenient.

[jennifer-shehane]

@Zzet-Z Running them now

[Zzet-Z]

@jennifer-shehane Oops,I neglected a test case, now it is updated, please help run it again when you are free.By the way, there are still a small part of failures that seem not to be caused by my changes, could you please help me check whether these need my attention, thx!

Dismissing my previous review to open up reviews for the team

[cypress-bot]

Released in 13.10.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.10.0, please open a new issue.