chore(dependency): Upgrade Electron 28 #28959

jennifer-shehane · 2024-02-16T15:54:14Z

Closes [Electron 28] - EPIC - Upgrade #28943

Additional details

Upgrade to Chromium 120
Upgrade to Node 18.18.2
Upgrade to v8 12.0

Related Docker Images PR https://github.com/cypress-io/cypress-docker-images/pull/1052/files

Steps to test

How has the user experience changed?

PR Tasks

Have tests been added/updated?
Has a PR for user-facing changes been opened in cypress-documentation?
Have API changes been updated in the type definitions?

cypress · 2024-02-16T16:47:02Z

6 flaky tests on run #55520 ↗︎

0	29255	1328	0	6

Details:

Merge branch 'develop' into electron-28
Project: cypress	Commit: `a589f05935`
Status: Passed	Duration: 19:37 💡
Started: May 21, 2024 7:03 PM	Ended: May 21, 2024 7:23 PM

net_stubbing.cy.ts • 1 flaky test • 5x-driver-electron

View Output

Test		Artifacts
... > stops waiting when an fetch request is canceled		`Test Replay`

net_stubbing.cy.ts • 2 flaky tests • 5x-driver-chrome:beta

View Output

Test		Artifacts
network stubbing > waiting and aliasing > yields the expected interception when two requests are raced		`Test Replay`
... > stops waiting when an fetch request is canceled		`Test Replay`

waiting.cy.js • 1 flaky test • 5x-driver-chrome:beta

View Output

Test		Artifacts
... > errors > throws when waiting for 2nd response to route		`Test Replay`

net_stubbing.cy.ts • 2 flaky tests • 5x-driver-webkit

View Output

Test Artifacts

... > with `resourceType` > can match a proxied image request by resourceType

    </td>
  </tr>
  <tr>
    <td colspan="2">
      <a href="https://cloud.cypress.io/projects/ypt4pf/runs/55520/overview/a7f3f50b-1d27-4926-948b-9b3a42fe96ec?reviewViewBy=FLAKY&utm_source=github&utm_medium=flaky&utm_campaign=view%20test">
        ... > stops waiting when an xhr request is canceled
      </a>
    </td>
    <td>
      
    </td>
  </tr></table>

Review all test suite changes for PR #28959 ↗︎

…nto electron-28

jennifer-shehane · 2024-02-20T21:24:18Z

packages/packherd-require/src/sourcemap-support.ts

@@ -213,7 +213,7 @@ class SourcemapSupport {
      frame = cloneCallSite(frame)

      frame.getFileName = function getFileName () {
-        return pos.source || pos.name || null
+        return pos.source || pos.name || undefined


This type check was failing, likely due to upgrading types/node. https://app.circleci.com/pipelines/github/cypress-io/cypress/59945/workflows/36318f1d-bf0e-42e7-b0bc-3fa50a5b29f5/jobs/2493950

jennifer-shehane · 2024-02-20T21:25:10Z

yarn.lock

-  integrity sha512-2s6B2CWZM//kPgwnuI0KrYwNjfdByE25zvAaEpq9IH4zcNsarH8Ihu/UuX6XMPEogDAxkuUFeZn60pXNHAqn3A==
+  version "3.54.0"
+  resolved "https://registry.yarnpkg.com/node-abi/-/node-abi-3.54.0.tgz#f6386f7548817acac6434c6cba02999c9aebcc69"
+  integrity sha512-p7eGEiQil0YUV3ItH4/tBb781L5impVmmx2E9FRKF7d18XXzp4PGT2tdYMFY6wQqgxD0IwNZOiSJ0/K0fSi/OA==


node-abi error was encountered, so needed to bump this. electron/forge#667

jennifer-shehane · 2024-02-21T18:49:11Z

packages/data-context/src/DataContext.ts

@@ -181,6 +181,7 @@ export class DataContext {
  @cached
  get cloud () {
    return new CloudDataSource({
+      // @ts-ignore
      fetch: (...args) => this.util.fetch(...args),


To address error below. Open to better ideas here. https://app.circleci.com/pipelines/github/cypress-io/cypress/59948/workflows/efa9b4b3-12ca-4f83-a8d7-d5c9186f28d4/jobs/2493976

jennifer-shehane · 2024-02-22T16:54:30Z

npm/puppeteer/tsconfig.json

@@ -16,7 +16,7 @@
    "types": [
      "cypress",
      "./support",
-      "./node_modules/@types/node"
+      "node"


To address this error: https://app.circleci.com/pipelines/github/cypress-io/cypress/59971/workflows/b10cb9c6-89ad-4a6b-8ae8-9ff9d8d6121e/jobs/2495052

jennifer-shehane · 2024-03-04T15:16:43Z

@MikeMcC399 Removed that reference.

…tron-28

…indow is never visited, avoiding net::ERR_INVALID_ARGUMENT issues [run ci]

AtofStryker · 2024-05-16T12:11:06Z

packages/driver/cypress/e2e/commands/net_stubbing.cy.ts

@@ -26,6 +26,7 @@ describe('network stubbing', { retries: 15 }, function () {

  beforeEach(function () {
    cy.spy(Cypress.utils, 'warning')
+    cy.visit('/fixtures/empty.html')


with Electron 28, we need to visit a url to establish origin , even though the document.location is already on the correct origin. A bit strange, but this does make sense for security purposes. I do not think this is a breaking change but more so an oddity with the test.

What is the error when this happens?

Will this be technically breaking? Folks could have tests that could have worked previously without a visit that no longer work?

The error was fairly vague via ERR_INVALID_ARGUMENT when an xhr request would fire. The only way I could resolve it was to visit and establish the origin before making requests to that origin server. By guess is it was a problem with the domain not being established while attempting to make same origin connections. This could technically be breaking, I wonder for those doing API testing, but I would also think most people doing API testing are doing so from cypress commands through the node API and not browser requests before visiting a page

AtofStryker · 2024-05-16T12:12:10Z

scripts/binary/trigger-publish-binary-pipeline.js

@@ -16,7 +16,7 @@ const { getNextVersionForBinary } = require('../get-next-version')
      job_name: process.env.CIRCLE_JOB,
      triggered_workflow_id: process.env.CIRCLE_WORKFLOW_ID,
      triggered_job_url: process.env.CIRCLE_BUILD_URL,
-      branch: process.env.CIRCLE_BRANCH,
+      branch: 'upgrade-electron-28',


we will need to remove this post merging (as well as merging the updated binary code)

…tron-28

bump Electron/node/node-abi + run extra workflows in CI

121aef3

jennifer-shehane self-assigned this Feb 16, 2024

empty commit

a74681e

jennifer-shehane mentioned this pull request Feb 16, 2024

Publish browsers-internal and base-internal for Electron 28 cypress-io/cypress-docker-images#1016

Merged

jennifer-shehane added 7 commits February 20, 2024 12:47

bump docker images to node + chrome versions for Electron 28

6e73a3e

bump node types

05f873d

bump xcode to version with default Node v18.17.1

1cbd4ea

Merge branch 'develop' into electron-28

fe34d4d

Bump types/node

837a079

Merge branch 'electron-28' of https://github.com/cypress-io/cypress i…

23cbb71

…nto electron-28

update getFileName to follow types of string or undefined

652eeaa

jennifer-shehane commented Feb 20, 2024

View reviewed changes

ts-ignore fetch spread

0d3bae1

jennifer-shehane commented Feb 21, 2024

View reviewed changes

jennifer-shehane added 4 commits February 21, 2024 13:57

yarn lock update

8e66ac2

bump system test yarn lock

2ef87a0

yarn/types node bump

3b9c2d9

fix types definition for node types

de8ab30

jennifer-shehane commented Feb 22, 2024

View reviewed changes

Merge branch 'develop' into electron-28

306e5b6

This comment was marked as resolved.

Sign in to view

Merge branch 'develop' into electron-28

5f40d20

This was referenced Mar 7, 2024

[Electron 28] Fix ts check errors #29082

Closed

[Electron 28] - fix binary smoke test failure #29083

Closed

Merge branch 'develop' into electron-28

1401928

jennifer-shehane marked this pull request as draft April 23, 2024 23:05

Merge branch 'develop' of github.com:cypress-io/cypress into electron-28

1113a99

AtofStryker added 2 commits May 15, 2024 11:04

fix stack integrity check

52addeb

use 18.20.2 docker image [run ci]

500225b

MikeMcC399 mentioned this pull request May 15, 2024

Ubuntu 24.04: MESA: error: ZINK: vkCreateInstance failed (VK_ERROR_INCOMPATIBLE_DRIVER) #29521

Open

ryanthemanuel and others added 6 commits May 15, 2024 11:02

Update binary-integrity-check-source.js

de6a1fd

Update smoke.js

e858554

update trigger binary publish and bump cache [run ci]

9985f75

Merge branch 'electron-28' of github.com:cypress-io/cypress into elec…

67c4065

…tron-28

bump cache [run ci]

ef8361c

fix issues with browser window sending cross origin requests as the w…

a32c241

…indow is never visited, avoiding net::ERR_INVALID_ARGUMENT issues [run ci]

AtofStryker assigned AtofStryker and unassigned jennifer-shehane May 16, 2024

AtofStryker reviewed May 16, 2024

View reviewed changes

update docker images [run ci]

9595366

AtofStryker marked this pull request as ready for review May 16, 2024 12:41

AtofStryker added 9 commits May 16, 2024 08:41

Merge branch 'develop' into electron-28

a5d92ae

add changelog entry

f871559

update to latest electron 28

aa36916

Merge branch 'electron-28' of github.com:cypress-io/cypress into elec…

b0276b6

…tron-28

fix error in changelog

c5c44af

fix snapshots in firefox with firefox 126 update

0d14d87

Merge branch 'electron-28' of github.com:cypress-io/cypress into elec…

1549bd2

…tron-28

polish firefox system tests for somewhat hacky work around

208bc8b

update cy-non-proxied image to fit base64 encoding in test

55287d4

AtofStryker force-pushed the electron-28 branch from f92681e to 55287d4 Compare May 16, 2024 19:28

AtofStryker and others added 2 commits May 17, 2024 10:50

empty commit to trigger ci [run ci]

8286d7b

Merge branch 'develop' into electron-28

f56bb33

AtofStryker requested review from mschile and ryanthemanuel May 21, 2024 18:36

Merge branch 'develop' into electron-28

a589f05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(dependency): Upgrade Electron 28 #28959

chore(dependency): Upgrade Electron 28 #28959

jennifer-shehane commented Feb 16, 2024 •

edited by AtofStryker

cypress bot commented Feb 16, 2024 •

edited

Review all test suite changes for PR #28959 ↗︎

jennifer-shehane Feb 20, 2024 •

edited

jennifer-shehane Feb 20, 2024

jennifer-shehane Feb 21, 2024

jennifer-shehane Feb 22, 2024

This comment was marked as resolved.

jennifer-shehane commented Mar 4, 2024

AtofStryker May 16, 2024

jennifer-shehane May 21, 2024

ryanthemanuel May 21, 2024

AtofStryker May 23, 2024

AtofStryker May 16, 2024

chore(dependency): Upgrade Electron 28 #28959

Are you sure you want to change the base?

chore(dependency): Upgrade Electron 28 #28959

Conversation

jennifer-shehane commented Feb 16, 2024 • edited by AtofStryker

Additional details

Steps to test

How has the user experience changed?

PR Tasks

cypress bot commented Feb 16, 2024 • edited

6 flaky tests on run #55520 ↗︎

Review all test suite changes for PR #28959 ↗︎

jennifer-shehane Feb 20, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment was marked as resolved.

jennifer-shehane commented Mar 4, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jennifer-shehane commented Feb 16, 2024 •

edited by AtofStryker

cypress bot commented Feb 16, 2024 •

edited

jennifer-shehane Feb 20, 2024 •

edited