Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: statusCode allow 999 #27853

Merged
merged 3 commits into from
Sep 25, 2023
Merged

fix: statusCode allow 999 #27853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a2d9b6
fix: statusCode allow 999
riwu Sep 21, 2023
5342e45
Merge branch 'develop' into patch-1
astone123 Sep 21, 2023
a753b33
Merge branch 'develop' into patch-1
Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion cli/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ _Released 09/19/2023 (PENDING)_

**Bugfixes:**

- Fixed an issue where actionability checks trigger a flood of font requests. Removing the font requests has the potential to improve performance and removes clutter from Test Replay. Addressed in [#27860](https://github.com/cypress-io/cypress/pull/27860)
- Fixed an issue where actionability checks trigger a flood of font requests. Removing the font requests has the potential to improve performance and removes clutter from Test Replay. Addressed in [#27860](https://github.com/cypress-io/cypress/pull/27860).
- Fixed network stubbing not permitting status code 999. Fixes [#27567](https://github.com/cypress-io/cypress/issues/27567). Addressed in [#27853](https://github.com/cypress-io/cypress/pull/27853).

## 13.2.0

Expand Down
2 changes: 1 addition & 1 deletion packages/driver/src/cy/net-stubbing/static-response-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export function validateStaticResponse (cmd: string, staticResponse: StaticRespo

// statusCode must be a three-digit integer
// @see https://tools.ietf.org/html/rfc2616#section-6.1.1
if (statusCode && !(_.isNumber(statusCode) && _.inRange(statusCode, 100, 999))) {
if (statusCode && !(_.isNumber(statusCode) && _.inRange(statusCode, 100, 1000))) {
err('`statusCode` must be a number between 100 and 999 (inclusive).')
}

Expand Down