Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge develop into release 13 #27537

Merged
merged 37 commits into from
Aug 15, 2023

Conversation

AtofStryker
Copy link
Contributor

  • Closes

Additional details

updates v13 with develop

Steps to test

How has the user experience changed?

PR Tasks

mike-plummer and others added 18 commits August 7, 2023 16:16
…7461)

* feat: Improve ignore capability to allow module & import matching

* Break out ignore into 'module' and 'import' lists to match separately based on use case
* Fix bugs in proxifier around class matching and function handling
* Add error handling to prevent total death of plugin for "standard" errors

* add missing word

---------

Co-authored-by: Mark Noonan <mark@cypress.io>
…e guide (#27266)

Co-authored-by: Mark Noonan <mark@cypress.io>
* chore: [run ci] does further prerequisites for webpack 5:
https://webpack.js.org/migrate/5/#make-sure-your-build-has-no-errors-or-warnings
https://webpack.js.org/migrate/5/#make-sure-to-use-mode
https://webpack.js.org/migrate/5/#update-outdated-options
https://webpack.js.org/migrate/5/#test-webpack-5-compatibility
app builds and runs locally. Time to test out in CI and see if buffer or
process need to be polyfilled by the build

* chore: upgrade to webpack 5 and do the bare minimum to get it working

* chore: get @packages/extension working

* chore: add TODOs to finish after webpack 5 update

* chore: update the webpack config for npm/webpack-batteries-included-preprocessor to be webpack 5 compliant

* chore: patch whatwg-url 7.1.0. package 'source-map' uses
whatwg-url@7.1.0 which has a dependency on punycode node expected API.
since punycode is now polyfilled for us implicitly via the punycode npm
package, the API signatures are a bit different
https://github.com/mathiasbynens/punycode.js/blob/main/punycode.js#L101
vs https://nodejs.org/api/punycode.html#punycodeucs2. The patch uses the
punycode npm package expected API and is needed for source maps to work
for cy.origin() dependencies for Cypress.require()

* chore: convert whatwg patch into dev patch as source-map is not installed when building the binary / installing prod dependencies

* chore: only move production level patches into the binary dist directory for yarn install --production

* chore: remove --openssl-legacy-provider code for node versions 17 and over as webpack has been updated to v5

* chore: fix the webpack-batteries-included-preprocessor tests by shimming the correct node globals and built ins

* chore: provide the define plugin and evalDevtoolPlugin again as we need define in order to build the react-dom library correctly in the bundle to not include the development version

* chore: updating v8 snapshot cache

* chore: updating v8 snapshot cache

* chore: updating v8 snapshot cache

* chore: fix the webpack preprocessor not to change promise references under the hood when compiling the first bundle, as it was causing the webpack preprocessor to hang as the reference itself was different

* chore: fix issues from readFile that were caused by Webpack 5 using 'path-browserify'

* chore: update chrome component testing snapshots to match Webpack 5 changes

* chore: fix mismatched snapshots from webpack 5 update

* chore: use Cypress.Buffer instead of Buffer for selectFile system test to avoid having to polyfill Buffer from webpack

* chore: fix system test webpack path that now includes e2e workspace

* chore: patch enhanced-resolve to properly discover the pnp api for the yarn_v3.1.1_pnp_spec.ts system test. see webpack/enhanced-resolve#263 for more details

* chore: set stats to 'none' for experimentalSingleTabMode to prevent different webpack compiled terminal formatting in the snapshot between local and CI.

* chore: fix node built in tests and configure webpack-batteries-included-preprocessor correctly

* chore: fallback to buffer correctly in config, even though there is no impact due to the provide plugin

* Update binary-cleanup.js to exclude added build dependencies for webpack
5 added by webpack-terser-plugin under the hood

* chore: add stream-browserify to webpack preprocessor batteries included as a dep as its used in the config [run ci]

* chore: make sure process and buffer are installed in the CLI for webpack provide

* chore: build cross platform binaries [run ci]

* chore: fix webpack evalDevToolPlugin instantiation [run ci]

* run all binary jobs [run ci]

* chore: updating v8 snapshot cache

* add find-up to the entry points that need to be kept

* chore: updating v8 snapshot cache

* chore: updating v8 snapshot cache

* chore: fix mocha build warnings

* chore: fix STRIPPED_INTEGRITY_TAG import warnings

* chore: add changelog event

---------

Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
Co-authored-by: Ryan Manuel <ryanm@cypress.io>
* chore: update build-npm-modules script

* chore: update build-npm-modules script

* chore: update build-npm-modules script

* chore: update build-npm-modules script

* chore: update lerna to 6

* [run ci]

* try caching build step

* we can't clean without building after

* add dependencies on scripts for npm packages

* update commands

* add config for data-context build step

* fix output configurations for npm packages, add gitignores

* revert changes to config and data-context build steps

* fix outputs

* run with cache

* fix outputs for cli

* actually fix outputs

* test with cache

---------

Co-authored-by: astone123 <adams@cypress.io>
* chore: update build-npm-modules script

* chore: update build-npm-modules script

* chore: update build-npm-modules script

* chore: update build-npm-modules script

* [run ci]

* we can't clean without building after

* update commands

* add config for data-context build step

* fix output configurations for npm packages, add gitignores

* revert changes to config and data-context build steps

* run with cache

* fix outputs for cli

* actually fix outputs

* test with cache

* chore: remove check-ts from Gulp and use Nx

* try limiting concurrency

* try concurrency 1

* add check-ts to packages where it is missing

---------

Co-authored-by: jordanpowell88 <jordan@jpdesigning.com>
* chore: update ts-loader from v8 to v9

* chore: update sass-loader from v10 to v13

* chore: update postcss-loader from v4 to v7

* chore: update mini-css-extract-plugin from v1 to v2

* chore: update html-webpack-plugin from v4 to v5

* chore: update css-loader from v5 to v6

* chore: update copy-webpack-plugin from v6 to v 11

* chore: update babel and babel loader to latest

* chore: remove Url import from validation as it should be available globally

* chore: update coffee-loader to latest and coffeescript to 2.6.0. coffee
script > 2.6.0 has issues with packheard transpilation, which likely
isnt worth the squeeze here to update it further

* chore: fix react component tests with webpack 4 as babl loader 9 only works with webpack 5, so we need ot pin the dep to 8 in the system-test project

* chore: remove dependency on file-loader and opt for ubilt in assert handling where applicable. Additionally, remove react-svg-loader and move to svgr loader inside the runner to bundle svgs needed for react components. Make sure that all SVGs are being imported correctly

chore: tell webpack preprocessor to process svgs inside of e2e tests for
the reporter. We did not need this before because we were using
react-svg-loader, which was used directly in source to process the svg
and allowed the svg to work under test. Since the source code is now
bundler independent, we need to tell cypress to bundle the svgs under
test. To do this, we pass our webpack config into
@cypress/webpack-preprocessor to allow loading the svgs. This is not a
breaking change.

* chore: switch from hash to contenthash

* chore: remove use of moduleIds for chunkIds as the defaults are likely better and handle caching/debugging better

* chore: mark tests that need to be updated as node 12 and 14 are no longer supported. node 12 doesnt ship with fs/promises, which causes fatal errors with babel-loader 9

try to test against new docker images [run ci]

* chore: updating v8 snapshot cache

* chore: updating v8 snapshot cache

* chore: updating v8 snapshot cache

* skip http/https form submittal unit tests for experimental webkit due to the clientRoute 404ing after submitting

* chore: pin webpack 5 for component tests in cy in cy to prevent using 4 from hoisted deps [run ci]

* build binaries [run ci]

* chore: bump circle cache [run ci]

* fix: turn off svgo from @svgr/webpack to preserve our scss class names within the svg. see https://react-svgr.com/docs/options/#svgo [run ci]

---------

Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
* chore: update tough-cookie from 4.0.0 to 4.1.3. requires v8 snapshot update

* fix: tough-cookie as of 4.1 doesn't default sameSite undefined to none any longer. However, we want to set sameSite === undefined to lax as the default as this is the case in every standard browser, except firefox. We did this previously and this is behavior we want to continue to preserve, even for security reasons

* chore: update v8 snapshots

* fix issue with global toString

* chore: run ci

* chore: update @cypress/request to 2.88.22 and @cypress/request-promise to 4.2.7 [run ci]

* remove jsdom and start-server-and-test

* revert @cypress/request back to 2.88.12

* update changelog entry

* remove uneeded deps

---------

Co-authored-by: Bill Glesias <bglesias@gmail.com>
Co-authored-by: Ryan Manuel <ryanm@cypress.io>
@cypress
Copy link

cypress bot commented Aug 11, 2023

12 flaky tests on run #49992 ↗︎

0 5332 78 0 Flakiness 12

Details:

update snapshot
Project: cypress Commit: 942e801716
Status: Passed Duration: 19:26 💡
Started: Aug 15, 2023 8:44 PM Ended: Aug 15, 2023 9:03 PM
Flakiness  spec_bridge.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
visits foobar.com and types foobar inside an input Test Replay Output
Flakiness  commands/unsupported_commands.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
cy.origin unsupported commands > cy.origin() is not yet supported Test Replay Output
Flakiness  commands/misc.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
cy.origin misc > .end() Test Replay Output
Flakiness  commands/spies_stubs_clocks.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
cy.origin spies, stubs, and clock > spy() Test Replay Output
Flakiness  commands/assertions.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
cy.origin assertions > .should() and .and() Test Replay Output

The first 5 flaky specs are shown, see all 10 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

astone123 and others added 11 commits August 11, 2023 15:02
* chore: remove flaky Percy snapshot from global-mode spec

* chore: remove flaky Percy snapshot from ConfigCode spec

* remove unintended change
BREAKING CHANGE: Since cypress now bundles with webpack v5, the minimum webpack version is now version 5 as this iswhat cypress will support in the monorepo moving forward. If you wish to use webpack 4, please use v2 of this package.
…webpack 4 based output and now needs to be updated to 5 (#27548)
@AtofStryker AtofStryker merged commit f1b3741 into release/13.0.0 Aug 15, 2023
78 of 80 checks passed
@AtofStryker AtofStryker deleted the chore/merge_develop_into_release_13 branch August 15, 2023 21:14
@cypress cypress bot mentioned this pull request Aug 15, 2023
3 tasks
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 29, 2023

Released in 13.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants