Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions: patch DNS issues on Mac OS runners #5813

Closed
wants to merge 2 commits into from

Conversation

oliver-sanders
Copy link
Member

There are DNS issues with the GitHub Mac OS runners resulting in reverse lookup failures causing Cylc test failures.

Hopefully the networking will be fixed before long, in the mean time, this workaround was suggested on the ticket.

See actions/runner-images#8649

@oliver-sanders
Copy link
Member Author

This patch fixes most, but not all of the DNS issues.

It would appear the hostname returned by reverse lookup results in "Host key verification failed":

2023-11-09T15:36:26+05:30 DEBUG - $ ssh -oBatchMode=yes -oConnectTimeout=10 Mac-1699523276107.local env CYLC_VERSION=8.3.0.dev CYLC_CONF_PATH=/private/var/folders/3s/vfzpb5r51gs6y328rmlgzm7c0000gn/T/tmp.FxeHKbLvTe/etc CYLC_COVERAGE=1 bash --login -c 'exec "$0" "$@"' cylc psutil  # returned 255
    Host key verification failed.

There is a Cylc / SSH configuration hack that could potentially be used to work around this.

@oliver-sanders oliver-sanders self-assigned this Nov 15, 2023
@oliver-sanders oliver-sanders changed the base branch from master to 8.2.x November 15, 2023 15:52
@oliver-sanders oliver-sanders changed the title actions: attempt to patch DNS issues on Mac OS runners actions: patch DNS issues on Mac OS runners Nov 15, 2023
@oliver-sanders oliver-sanders added this to the cylc-8.2.4 milestone Nov 15, 2023
@@ -248,6 +269,7 @@ jobs:
-exec echo '====== {} ======' \; -exec cat '{}' \;

- name: Set artifact upload name
if: always()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated: fixes an issue where all of the cylc_run uploads where getting merged because this step wasn't run.

Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get this merged (into 8.2.x) for the time being?

@MetRonnie MetRonnie added the infrastructure GH Actions, Codecov etc. label Dec 12, 2023
@oliver-sanders
Copy link
Member Author

It doesn't work.

@MetRonnie
Copy link
Member

IMO it's better than the current situation because it works for the fast tests and cuts down the functional test failures to ~4

@oliver-sanders
Copy link
Member Author

For the time being we have worked around the issue by downgrading to the macos 11 images (note 12 is the current default image, the 13 beta image has the same issue as the 12 image).

@oliver-sanders oliver-sanders removed this from the cylc-8.3.0 milestone Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure GH Actions, Codecov etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants