-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
completion: add additional documentation #731
Conversation
cc05c29
to
f272a06
Compare
(rebased) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of minor suggestions
required output in the graph, then these must also | ||
be produced. | ||
|
||
At Cylc 8.3.0 it is now possible to manually configure this completion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No biggie, but we'd normally not say this here (put an "added in version ..." note instead?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we'd do that in changes.rst
- or the whole document would be a storm of .. versionadded::
directives.
Co-authored-by: Hilary James Oliver <hilary.j.oliver@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this - merge with or without my suggestion.
I'm not sure Hilary's outstanding comment is a good idea either.
Co-authored-by: Tim Pillinger <26465611+wxtim@users.noreply.github.com>
Just the two errors present on master, being fixed in another PR:
|
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.