Fixed bStrictObjectTypeChecking not enforced for array elements #225
+36
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dktapps
changed the title
|
Thank you for the patch! |
cweiske
pushed a commit
that referenced
this pull request
Sep 8, 2024
Simple types like strings in arrays that expect an object will throw an exception now when bStrictObjectTypeChecking is enabled. BC break! Resolves: #225
|
Released with v5.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this created some security issues in my projects.
Might be worth having createInstance() check if the object in question has any @required properties.
In the second case, the model's @required properties wouldn't be populated, but no error would be thrown.
This makes it a requirement to use
bStrictObjectTypeCheckingin any security-conscious situation, but it wasn't considered at all in the case of arrays.