Fix crash for property with case difference and without docblock #222
+19
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7dc32f5 introduced a possible crash under a very specific situation:
In this situation, the following crash occurs:
The reason is that inside
inspectProperty()
,$class
is null when the property is not found by exact name. Later, the code attempts to find the property case-insensitively, but then$class
is leftfalse
. This leads to a crash in new code introduced by 7dc32f5.The attached patch contains a test that fails when the change in
JsonMapper.php
is not applied.