Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: use toggle in main window triggered action #106

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

trdthg
Copy link
Contributor

@trdthg trdthg commented Feb 24, 2024

trying to fix #58, There is only one button now.

Any suggestions? Should I continue?

@jdupak jdupak self-requested a review February 24, 2024 09:25
@jdupak
Copy link
Collaborator

jdupak commented Feb 24, 2024

Hi @trdthg, welcome, and thanks for your contribution! I will review it soon.

However, one issue is, that we never concluded on whether this is a good idea for user experience. That is why it was not marked with any issue labels. Unfortunately, we had this discussion in person, so it was not visible with the issue. Sorry for that.

@ppisa I am thinking that we might publish this in an extra WASM URL and ask students to comment on it on Discord. What do you think?

@ppisa
Copy link
Member

ppisa commented Mar 4, 2024

I am not sure what is the best direction there. I have nothing against inclusion of support for toggle as addition to show in the code in general. But the series should be cleaned. As for shortcuts, I am not sure. I think that it is better to keep option, which ensures that pressing the combination ensures activation/show of the dock and be sure that it is visible. That is separate show only shortcut is useful. Close is easy by mouse, because you see what is there and you want to remove from the screen. If there is enough unallocated shortcuts then separate combination for making dock visible and another (for example with Ctrl or Shift) to close dock could be useful. But toggling does not lead to steady state and you need to analyze the first if dock is missing or moved somewhere where it is not well visible and then decode if to press it to make dock visible or if mouse drag is required.

So I am not sure if this change is useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Sidebar visibility actions should toggle the sidebar instead of only opening it
3 participants