Update 2451-modules-compat.md fix typo #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Gillette <extemporalgenome@gmail.com>
extemporalgenome
force-pushed
the
patch-1
branch
from
5b6b9e4
to
7b01f31
Compare
cueckoo
pushed a commit
that referenced
this pull request
Jun 3, 2024
Spotted by extemporalgenome in #2 and #3 but because of Gerrit being strict that the commit email addressed and "Signed-Of-By" are the same it was quicker/simpler to make the changes again. Signed-off-by: Paul Jolly <paul@myitcv.io> Change-Id: I6d85fef64939c6f920c48c594a7ec844fe06b5c8 Reviewed-on: https://review.gerrithub.io/c/cue-lang/proposal/+/1195638 Reviewed-by: Daniel Martí <mvdan@mvdan.cc> TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
|
Thanks for taking the time to submit these PRs. It seems GerritHub is more strict that GitHub's DCO check; GerritHub complained about the difference between your commit author email address and the "Signed-Off-By". Rather than make you go through a dance of fixing that up, I took the liberty of incorporating both changes into https://review.gerrithub.io/c/cue-lang/proposal/+/1195638 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.