This repository has been archived by the owner on Apr 26, 2021. It is now read-only.
linux/process: Support reading empty values from /proc/pid/status #3036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file /proc/<pid>/status provides information about a process in the format 'key: value'. The parsing of this file failed if 'value' was empty. Add an dummy value that will be taken in case the real value from the status file does not exist. Additionally, update the log message from the parsing code to also output the exception, if one is raised. Closes: cuckoosandbox#3035
omeranson
force-pushed
the
fix-proc-status
branch
from
115f8dd
to
8e88110
Compare
|
@botherder Could you please take a look? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file /proc//status provides information about a process in
the format 'key: value'. The parsing of this file failed if 'value'
was empty.
Add an dummy value that will be taken in case the real value from
the status file does not exist.
Additionally, update the log message from the parsing code to also
output the exception, if one is raised.
Closes: #3035
Thanks for contributing! But first: did you read our community guidelines?
https://cuckoo.sh/docs/introduction/community.html
What I have added/changed is:
Add an dummy value that will be taken in case the real value from
the status file does not exist.
Additionally, update the log message from the parsing code to also
output the exception, if one is raised.
The goal of my change is:
Maker reading process status data more robust. Have it support cases where some values are empty.
What I have tested about my change is:
The issue reproduced without the change. Adding the change resolves the issue.